[m-rev.] for review: a string builder that tracks line numbers
Zoltan Somogyi
zoltan.somogyi at runbox.com
Mon Sep 2 18:10:39 AEST 2024
On Sun, 1 Sep 2024 22:36:27 +1000, Julien Fischer <jfischer at opturion.com> wrote:
> On Sat, 31 Aug 2024 at 11:13, Zoltan Somogyi <zoltan.somogyi at runbox.com> wrote:
> >
> > The implementation is trivial; I am looking for
> > feedback on the concept, and on the name of the module.
> > I don't particularly like builder_nl, but I can't think of anything better.
>
> line_builder or lines_builder.
I followed your suggestions, and added the top-of-module comment.
The final diff is attached. Thanks for the review.
Zoltan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Log.lb
Type: application/octet-stream
Size: 2310 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20240902/b4616ec8/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIFF.lb
Type: application/octet-stream
Size: 10618 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20240902/b4616ec8/attachment-0001.obj>
More information about the reviews
mailing list