[m-rev.] for post-commit review: --deep-std-name

Julien Fischer jfischer at opturion.com
Mon Oct 14 00:08:26 AEDT 2024


On Sun, 13 Oct 2024 at 19:47, Zoltan Somogyi <zoltan.somogyi at runbox.com> wrote:

> Add --deep-std-name option to control deep prof file names.
>
> When this new runtime option is specified, the runtime system will use
> Deep.{data,procrep} as the names of the files it writes out.
>
> runtime/mercury_engine.h:
>     Add a flag to the engine that records whether this option has been
>     specified or not.
>
> runtime/mercury_wrapper.c:
>     Set the flag if/when we see the --deep-std-name option.
>
> runtime/mercury_deep_profiling.c:
>     If the new flag is set, use Deep.{data,procrep} as filenames.
>
> doc/user_guide.texi:
>     Document the new option.
>
> tools/bootcheck:
>     Specify the new option for bootchecks.
>
> tests/debugger/Mmakefile:
> tests/declarative_debugger/Mmakefile:
> tests/hard_coded/Mmakefile:
> tests/par_conj/Mmakefile:
> tests/stm/Mmakefile:
>     When specifying a value of MERCURY_OPTIONS that overrides the value
>     set by tools/bootcheck, include --deep-std-name in that value.

That looks fine.

Julien.


More information about the reviews mailing list