[m-rev.] for review: start on replacing --intermod-directories and related options

Zoltan Somogyi zoltan.somogyi at runbox.com
Fri Nov 15 14:44:36 AEDT 2024


On 2024-11-15 14:33 +11:00 AEDT, "Julien Fischer" <jfischer at opturion.com> wrote:
>> +% Whether the deconstruct_univ predicate below terminates or not is
> determined
>> +% entirely by whether private_builtin.typed_unify terminates or not.
> However,
>> +% private_builtin.opt and private_builtin.trans_opt in the library
> directory
>> +% disagree about this: the .opt file gives typed_unify's termination
> status
>> +% as can_loop, while .trans_opt gives it as cannot_loop.
> 
> That initially struck me as strange, but it is correct. Proving termination
> of typed_unify/2 requires knowing that type_of/1 terminates and we can only
> know that from type_desc.opt.

I added a sentence to the above comment explaining this.

> (I think the comment in compiler/termination.m above
> set_compiler_gen_terminates/6 is wrong: it implies that the termination
> status
> of *all* predicates in builtin and private_builtin is set by that code, but
> doesn't seem to be what it actually does.)

I will update that comment, in a separate commit.

> The diff looks fine.

Thanks for the review.

Zoltan.


More information about the reviews mailing list