[m-rev.] for post-commit review: make diagnostic about coerce fails give the reason

Zoltan Somogyi zoltan.somogyi at runbox.com
Tue May 28 13:23:21 AEST 2024


On 2024-05-28 12:35 +10:00 AEST, "Peter Wang" <novalazy at gmail.com> wrote:
> Actually, you can coerce from a type to the same type. I have been
> considering adding a warning about such redundant coercions, though.

Ok. I can change both the wording and the severity here to generate
a warning rather than an error, but I need to know from you: is
report_invalid_coerce_from_to going to be *called* in such cases?

> That looks fine otherwise.

Thank you.

Zoltan.


More information about the reviews mailing list