[m-rev.] for post-commit review: use color in typecheck_errors_undef.m and others

Peter Wang novalazy at gmail.com
Thu May 23 18:17:15 AEST 2024


On Mon, 20 May 2024 18:30:34 +1000 "Zoltan Somogyi" <zoltan.somogyi at runbox.com> wrote:
> For review by anyone.
> 
> Zoltan.

I noticed some doubled-up words while glancing through the .err_exps.

> diff --git a/tests/invalid/bad_fact_table_decls.err_exp b/tests/invalid/bad_fact_table_decls.err_exp
> index 1aae7bc20..7f53ab8e4 100644
> --- a/tests/invalid/bad_fact_table_decls.err_exp
> +++ b/tests/invalid/bad_fact_table_decls.err_exp
...
> -bad_fact_table_decls.m:057:   `table_3'/3 mode 0 to be either fully input or
> -bad_fact_table_decls.m:057:   fully output, but the second argument is neither.
> +bad_fact_table_decls.m:057:   `table_3'/3 mode 0 to be either fully input or
> +bad_fact_table_decls.m:057:   fully output, but the second argument is is
> +bad_fact_table_decls.m:057:   neither.

"is" is doubled.

> diff --git a/tests/invalid/bad_format_call.err_exp b/tests/invalid/bad_format_call.err_exp
> index c85259072..030932916 100644
> --- a/tests/invalid/bad_format_call.err_exp
> +++ b/tests/invalid/bad_format_call.err_exp
> @@ -1,51 +1,51 @@
...
>  bad_format_call.m:055: Error: in the second argument of `:- pragma format_call'
> -bad_format_call.m:055:   declaration for predicate `type_test_1'/4:
> +bad_format_call.m:055:   declaration for predicate `type_test_1'/4:
>  bad_format_call.m:055:   the first argument of `format_string_values' specifies
>  bad_format_call.m:055:   argument number 2 as holding a format string, but but

"but" is doubled.

Peter


More information about the reviews mailing list