[m-rev.] for post-commit review: use color in parse_pragma_foreign.m
Julien Fischer
jfischer at opturion.com
Wed May 15 16:41:01 AEST 2024
On Wed, 15 May 2024, Zoltan Somogyi wrote:
> Use color in parse_pragma_foreign.m.
>
> compiler/parse_pragma_foreign.m:
> Add color to the diagnostics generated by this module.
>
> In a few cases, improve the wording of the diagnostic. In several cases,
> change the diagnostic's wording to follow our standard patterns.
>
> In a few cases, simplify the logic of the main code.
>
> compiler/parse_util.m:
> Add a ContextPieces argument to an auxiliary predicate,
> parse_list_elements.
>
> compiler/parse_pragma.m:
> compiler/parse_pragma_analysis.m:
> compiler/parse_pragma_tabling.m:
> Conform to the changes in parse_util.m.
>
> tests/invalid_make_int/bad_foreign_type_int.int_err_exp:
> tests/invalid_nodepend/bad_foreign_code.err_exp:
> tests/invalid_nodepend/bad_foreign_decl.err_exp:
> tests/invalid_nodepend/bad_foreign_enum.err_exp:
> tests/invalid_nodepend/bad_foreign_export.err_exp:
> tests/invalid_nodepend/bad_foreign_export_enum.err_exp:
> tests/invalid_nodepend/bad_foreign_import_module.err_exp:
> tests/invalid_nodepend/bad_foreign_proc.err_exp:
> tests/invalid_nodepend/bug363.err_exp:
> tests/invalid_nodepend/foreign_enum_import.err_exp:
> Expect updated diagnostics.
That looks fine.
Julien.
More information about the reviews
mailing list