[m-rev.] for post-commit review: use color in parse_goal.m

Zoltan Somogyi zoltan.somogyi at runbox.com
Wed May 15 09:21:18 AEST 2024


On 2024-05-15 08:36 +10:00 AEST, "Zoltan Somogyi" <zoltan.somogyi at runbox.com> wrote:
> There were few test cases affected by this change compared
> to the number of error-spec-construction-sites updated by it,
> so it seems like most of those sites don't have tests for their output.
> So keep an eye out for any unwanted changes appearing
> "in the wild", so to speak.

The attached diff for adding color to parse_dcg_goal.m affects
NO test cases, which is a bit disturbing. (Only a bit, because most
of the error messages are for situations that require really stupid code
to trigger.)
 
Zoltan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Log.cpdg
Type: application/octet-stream
Size: 178 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20240515/0a5892a7/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIFF.cpdg
Type: application/octet-stream
Size: 5850 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20240515/0a5892a7/attachment-0001.obj>


More information about the reviews mailing list