[m-rev.] for post-commit review: use color in parse_inst_mode_defn.m

[Zoltan Somogyi]

On 2024-05-15 00:46 +10:00 AEST, "Julien Fischer" <jfischer at opturion.com> wrote:
>> diff --git a/tests/invalid_nodepend/bad_foreign_export_enum.err_exp b/tests/invalid_nodepend/bad_foreign_export_enum.err_exp
>> index 3eae66549..1113211c1 100644
>> --- a/tests/invalid_nodepend/bad_foreign_export_enum.err_exp
>> +++ b/tests/invalid_nodepend/bad_foreign_export_enum.err_exp
>> @@ -25,8 +25,8 @@ bad_foreign_export_enum.m:030: In the third argument of
>>  bad_foreign_export_enum.m:030:   `:- pragma foreign_export_enum' declaration:
>>  bad_foreign_export_enum.m:030:   error: expected a list of attributes, got
>>  bad_foreign_export_enum.m:030:   `1234'.
>> -bad_foreign_export_enum.m:031: Error: expected a list of mapping elements, got
>> -bad_foreign_export_enum.m:031:   `5678'.
>> +bad_foreign_export_enum.m:031: Error: expected a list of mapping elements, got
>> +bad_foreign_export_enum.m:031:   `5678'.
> 
> That's not a great error message, why do we not provide the same context we
> do for the others, e.g.
> 
>      In fourth argument of
>      `:- pragma foreign_export_enum' declaration:
>       error: expect a list of mapping elements, got `5678'
> ?

That message is generated by parse_pragma_foreign.m, which I
have not colorized yet. I will fix it when I get there.

> The diff looks fine.

Thank you.

Zoltan.