[m-rev.] for post-commit review: color in parse_inst_mode_name.m

Julien Fischer jfischer at opturion.com
Wed May 15 00:29:38 AEST 2024


On Tue, 14 May 2024, Zoltan Somogyi wrote:

> Use color in parse_inst_mode_name.m.
> 
> compiler/parse_inst_mode_name.m:
>     Add color to the diagnostics generated by this module.
>
>     In a few cases, improve the wording of the diagnostic, and/or make
>     the wording of different but related diagnostics more consistent.
>
>     Implement parse_higher_order_mode by *calling* parse_higher_order_inst
>     and post-processing its results, instead of duplicating pretty much
>     all of its code.
> 
> tests/invalid_nodepend/bad_with_inst.err_exp:
> tests/invalid_nodepend/combined_ho_type_inst_1.err_exp:
> tests/invalid_nodepend/impl_def_literal_syntax.err_exp:
> tests/invalid_nodepend/inst_list_dup.err_exp:
> tests/invalid_nodepend/kind.err_exp:
> tests/invalid_nodepend/predmode.err_exp:
> tests/invalid_nodepend/test_with_type.err_exp:
>     Expect updated diagnostics.

That's fine.

Julien.


More information about the reviews mailing list