[m-rev.] for post-commit review: use color in two more modules

Julien Fischer jfischer at opturion.com
Sun May 12 02:08:33 AEST 2024


On Sat, 11 May 2024, Zoltan Somogyi wrote:

> Use color in adding foreign enums/checking types.
> 
> compiler/add_foreign_enum.m:
> compiler/check_type_inst_mode_defns.m:
>     Add color to the diagnostics generated by these modules.
>
>     In a few cases, improve the wording of the diagnostic.
> 
> tests/invalid/abstract_solver_type.err_exp:
> tests/invalid/any_mode.err_exp:
> tests/invalid/ee_invalid.err_exp:
> tests/invalid/exported_foreign_enum.err_exp:
> tests/invalid/foreign_enum_invalid.err_exp:
> tests/invalid/foreign_solver_type.err_exp:
> tests/invalid/foreign_type_visibility.err_exp:
> tests/invalid/pragma_qual_error.err_exp:
> tests/invalid/repeated_field_name.err_exp:
> tests/invalid/subtype_foreign.err_exp:
> tests/invalid/type_with_no_defn.err_exp:
> tests/invalid/types2.err_exp:
> tests/invalid_nodepend/bad_foreign_type.err_exp:
> tests/invalid_nodepend/types.err_exp:
> tests/invalid_nodepend/uu_type.err_exp:
> tests/invalid_nodepend/where_abstract_enum.err_exp:
> tests/warnings/abstract_type_decl.err_exp:
>     Expect updated diagnostics.

That's fine.

Julien.


More information about the reviews mailing list