[m-rev.] for review: announce color on the website

Peter Wang novalazy at gmail.com
Mon Jun 24 15:07:39 AEST 2024


On Mon, 24 Jun 2024 13:48:42 +1000 "Zoltan Somogyi" <zoltan.somogyi at runbox.com> wrote:
> 
> I installed a compiler yesterday that has 0e29 in it. With that compiler in my path, I can now
> compile other workspaces *with* color diagnostics without any of the relevant envvars being set.
> 

Never mind, I can confirm colors are enabled by default with the ROTD.
Probably my mercury workspace was not actually up-to-date.

> > Will you implement the isatty check?
> 
> For the reasons I mentioned the last time this topic came up, no.
> You are welcome to do so yourself, but you will have to deal with
> the issues that come with it, the main one being that diagnostics generated
> by mmc --make can go to BOTH a tty and a non-tty.

I'll take a look.

> > In particular, the vim quickfix mode doesn't know anything about ANSI
> > escape sequences.
> 
> This is the first time I have heard of that mode, though I do know that
> vim in general does not handle those escape sequences.

I use it a lot, with C compilers, with Mercury, with grep and the like.

> > Anyone using quickfix would need to explicitly disable
> > color.
> 
> Would it take more effort than setting the compiler not to "mmc",
> but to "mmc --no-color-diagnostics"?

That would work, but it would be better if you didn't have to.

Peter


More information about the reviews mailing list