[m-rev.] for review: enable, document and announce color diagnostics

[Julien Fischer]

On Sun, 23 Jun 2024 at 09:46, Zoltan Somogyi <zoltan.somogyi at runbox.com> wrote:
>
>
> On 2024-06-23 02:18 +10:00 AEST, "Julien Fischer" <jfischer at opturion.com> wrote:
> > On Sat, 22 Jun 2024 at 16:02, Zoltan Somogyi <zoltan.somogyi at runbox.com> wrote:
> >>
> >> Fir review by anyone. I am particularly looking for feedback
> >> on three new XXXs in the user guide.
> >
> > gmail is not playing nicely with my usual mail client at the moment,
> > so I have attached
> > my review comments instead.
>
> I addressed all your points except one, which is documenting
> the default color scheme. At the moment, it is light16, which I don't like,
> because it specifies only reassignable color slots, and not actual colors.
> It will therefore look different, possibly radically different, from the intended look
> on any terminal that uses a nonstandard color palette. I would feel much
> more comfortable naming the default scheme if it were light256,
> which does not have this problem. I think the proportion of terminal
> emulators set to use nonstandard color palettes is likely to be way higher
> than the proportion that support 4-bit color but do not support 8-bit,
> since I expect that latter to be vanishingly rare.

That seems to be conflating two issues:
1) What is the default color scheme?
2) Should that default be documented?

The answer to the second question is yes.  As a user, in the case
where my terminal
settings cause the default to look bad, I need to to know what that
default scheme
it is in order to address those problems. We should make finding that
out as easy as possible.

As to the first question, I'm not really the right person to answer it
as I can't recall
ever changing my terminal's color scheme.

> Does that file constitute the entirety of your review, or should I wait
> for a second half?

I'm happy for you to commit as-is.  I will do another read through
once everything is in place
and make any further review comments in the form of diffs for proposed changes.

Julien.