[m-rev.] for review: enable, document and announce color diagnostics

[Zoltan Somogyi]

On 2024-06-23 02:18 +10:00 AEST, "Julien Fischer" <jfischer at opturion.com> wrote:
> On Sat, 22 Jun 2024 at 16:02, Zoltan Somogyi <zoltan.somogyi at runbox.com> wrote:
>>
>> Fir review by anyone. I am particularly looking for feedback
>> on three new XXXs in the user guide.
> 
> gmail is not playing nicely with my usual mail client at the moment,
> so I have attached
> my review comments instead.

I addressed all your points except one, which is documenting
the default color scheme. At the moment, it is light16, which I don't like,
because it specifies only reassignable color slots, and not actual colors.
It will therefore look different, possibly radically different, from the intended look
on any terminal that uses a nonstandard color palette. I would feel much
more comfortable naming the default scheme if it were light256,
which does not have this problem. I think the proportion of terminal
emulators set to use nonstandard color palettes is likely to be way higher
than the proportion that support 4-bit color but do not support 8-bit,
since I expect that latter to be vanishingly rare.

Does that file constitute the entirety of your review, or should I wait
for a second half?

Zoltan.