[m-rev.] for post-commit review: allow some colors to be left unspecified

Zoltan Somogyi zoltan.somogyi at runbox.com
Sat Jun 8 04:29:45 AEST 2024


On 2024-06-07 14:48 +10:00 AEST, "Peter Wang" <novalazy at gmail.com> wrote:
>> This would add the informational message to the output of a
>> compiler invocation only when that output could have been affected
>> by the color being left unspecified.
> 
> Sounds reasonable to me.

The attached diff implements this scheme. It needs a test case,
but I will add it after I arrange for color scheme options to be processed
in the agreed order.

Thanks for the review.

Zoltan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Log.cse
Type: application/octet-stream
Size: 746 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20240608/a34c1aeb/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIFF.cse
Type: application/octet-stream
Size: 13936 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20240608/a34c1aeb/attachment-0001.obj>


More information about the reviews mailing list