[m-rev.] for review: Add --error-files-in-subdir option.

Peter Wang novalazy at gmail.com
Wed Jul 31 12:17:12 AEST 2024


On Fri, 26 Jul 2024 09:57:51 +0200 "Zoltan Somogyi" <zoltan.somogyi at runbox.com> wrote:
> > diff --git a/compiler/file_names.m b/compiler/file_names.m
> > index d28b93b9c..c0ed677c2 100644
> > --- a/compiler/file_names.m
> > +++ b/compiler/file_names.m
> > @@ -198,6 +198,11 @@
> >              % directory, or into a non-grade-specific subdirectory, or into
> >              % a grade-specific subdirectory, with search being irrelevant.
> >  
> > +    ;       ext_cur_ngs_gs_err(ext_cur_ngs_gs_err)
> > +            % .err files can be placed into the current directory, or into a
> > +            % non-grade-specific subdirectory, or into a grade-specific
> > +            % subdirectory, depending on options.
> 
> That comment also applies to the existing ext_cur_ngs_gs category.
> You need to document the difference, which is that the options you
> are talking about extend *beyond* --use-subdirs/--use-grade-subdirs,
> and include --error-files-in-subdir.
> 

Fixed.

> > diff --git a/compiler/options.m b/compiler/options.m
> > index 526319d6c..8e13f11ff 100644
> > --- a/compiler/options.m
> > +++ b/compiler/options.m
> >  long_table("std-int-file-not-written-msgs",
> >                      std_int_file_not_written_msgs).
> >  long_table("search-directory",     search_directories).
> > @@ -7015,6 +7018,10 @@ options_help_build_system(Stream, !IO) :-
> >          "\tthe current directory.",
> >          "\t`--use-grade-subdirs' does not work with Mmake (it does",
> >          "\twork with `mmc --make').",
> > +        "--error-files-in-subdir",
> > +        "\tGenerate .err files under the `Mercury' subdirectory",
> > +        "\trather than in the current directory.",
> > +        "\t(This option is only supported by `mmc --make'.)",
> 
> I don't think this explanation works, because even if this option is enabled,
> .err files *still* get put into the current directory, unless --use-subdirs/--use-grade-subdirs
> is specified.

mmc --make implies --use-subdirs. I've adjusted the explanation, though.
Thanks.

Peter


More information about the reviews mailing list