[m-rev.] for review: Put .mh files into Mercury/mhs subdirectory.

Peter Wang novalazy at gmail.com
Wed Jul 24 10:48:58 AEST 2024


On Tue, 23 Jul 2024 21:00:05 +1000 Julien Fischer <jfischer at opturion.com> wrote:
> On Tue, 23 Jul 2024 at 14:33, Peter Wang <novalazy at gmail.com> wrote:
> 
> > diff --git a/NEWS.md b/NEWS.md
> > index 8f461025d..d78b4097f 100644
> > --- a/NEWS.md
> > +++ b/NEWS.md
> 
> > @@ -66,16 +72,16 @@ Changes that may break compatibility
> >
> >  * Some (undocumented) mmake variables in compiler-generated `.dv` files
> >    have been renamed:
> > -
> > -    program.cs          -> program.all_cs
> > -    program.os          -> program.all_os
> > -    program.pic_os      -> program.all_pic_os
> > -    program.javas       -> program.all_javas
> > -    program.css         -> program.all_css
> >
> > -    program.all_mhs     -> program.mhs_to_clean
> > -    program.all_mihs    -> program.mihs_to_clean
> > -    program.all_int0s   -> program.int3s_to_clean
> > +    program.cs          -> program.all_cs
> > +    program.os          -> program.all_os
> > +    program.pic_os      -> program.all_pic_os
> > +    program.javas       -> program.all_javas
> > +    program.css         -> program.all_css
> > +
> > +    program.all_mhs     -> program.mhs_to_clean
> > +    program.all_mihs    -> program.mihs_to_clean
> > +    program.all_int0s   -> program.int3s_to_clean
> 
> Why did you delete the trailing whitespace here?  It is acting as a line break.
> (The rendered version on Github looks uglier in the absence of those
> line breaks IMO.)

Oops, I didn't see that. I changed it to a code block as trailing spaces
are liable to be deleted again.

Peter


More information about the reviews mailing list