[m-rev.] for post-commit review: fix github issue 133

Zoltan Somogyi zoltan.somogyi at runbox.com
Fri Jul 12 15:15:35 AEST 2024



On Fri, 12 Jul 2024 14:59:51 +1000, Peter Wang <novalazy at gmail.com> wrote:
> I saw an old workaround around here that we might want to remove:
> 
>                 not needs_workaround(reg(reg_r, 1), NewCond)

Yes, I thought about that too. But I remember that when we added that code
to work around a bug in some then-current (and now-ancient) C compilers,
that bug was tickled very rarely. This means that removing the workaround
would yield a speedup only on very rare occasions. And that optimization
has only a tiny effect on each application; its effect is (or at least was then)
measurable only when applied in lots of places. The compile-time cost
of the test is likewise negligible.

> The diff seems fine (I'm not familiar with the code).

Thanks for the review.

Zoltan.





More information about the reviews mailing list