[m-rev.] for review: Add a tool to help maintain Copyright lines.
Peter Wang
novalazy at gmail.com
Mon Feb 12 11:15:26 AEDT 2024
On Fri, 09 Feb 2024 18:28:31 +1100 "Zoltan Somogyi" <zoltan.somogyi at runbox.com> wrote:
>
> On 2024-02-09 18:17 +11:00 AEDT, "Peter Wang" <novalazy at gmail.com> wrote:
> >
> > What should I name the directory, update_copyright? Or maybe git_hooks?
>
> Probably the latter, since it is more future-proof.
>
Ok.
> > I tried it, but I don't find it better for two reasons:
> >
> > There is no read_input_stream_as_lines so the stdin case ends up
> > having to call read_file_as_string and split_into_lines.
> > (We could delete the code for stdin as well; /dev/stdin can be passed on
> > the command line if it's useful.)
>
> The NonOptionArgs = [] case can just invoke process_file on /dev/stdin.
Actually, I was wrong. First, writing to /dev/stdin won't produce the
output on standard output. Second, in the NonOptionArgs = [] case,
we don't want to produce any additional output on standard output.
I've left the code as-is.
Peter
More information about the reviews
mailing list