[m-rev.] for post-commit review: --c-incl-dir-external

Zoltan Somogyi zoltan.somogyi at runbox.com
Mon Dec 23 16:01:05 AEDT 2024



On Sun, 22 Dec 2024 15:04:56 +1100, Julien Fischer <jfischer at opturion.com> wrote:
> >  @c (or its abbreviated synonym).
> >  @c
> > - at c XXX Should we add something to specify that unlike the legacy options,
> > - at c the arguments of these options never require any directory name components
> > - at c that would be added by --use-subdirs/--use-grade-subdirs?
> > + at c Note that
> > + at c the @var{workspace_directory} and @var{install_directory} arguments
> > + at c should name directories that contain a @samp{MercurySystem} directory.
> 
> I suggest adding that the argument does not need to contain the MercurySystem
> component itself.
> 
> That looks fine otherwise.

Thanks for that. I followed both your suggestions.

Zoltan.





More information about the reviews mailing list