[m-rev.] for review: --warn-repeated-singleton-vars

[Zoltan Somogyi]

On Tue, 10 Dec 2024 14:32:28 +1100, Julien Fischer <jfischer at opturion.com> wrote:
> On Tue, 10 Dec 2024 at 04:28, Zoltan Somogyi <zoltan.somogyi at runbox.com> wrote:
> >      ;
> >          GoalExpr = call_foreign_proc(Attrs, PredId, ProcId, Args, _, _,
> >              PragmaImpl),
> >          Context = goal_info_get_context(GoalInfo),
> >          Lang = get_foreign_language(Attrs),
> >          NamesModes = list.map(foreign_arg_maybe_name_mode, Args),
> > -        warn_singletons_in_pragma_foreign_proc(!.Info ^ wi_module_info,
> > -            PragmaImpl, Lang, NamesModes, Context, !.Info ^ wi_pf_sna,
> > +        % ZZZ
> > +        warn_singletons_in_pragma_foreign_proc(Params ^ wp_module_info,
> > +            PragmaImpl, Lang, NamesModes, Context, Params ^ wp_pf_sna,
> >              PredId, ProcId, [], PragmaSpecs),
> >          add_warn_specs(PragmaSpecs, !Info)
> 
> Have you left that ZZZ there for a reason?

Yes. It was a reminder to add the comment in the now-attached diff.

> The diff looks fine otherwise.

Thanks for the review.

Zoltan.



-------------- next part --------------
A non-text attachment was scrubbed...
Name: Log.ws
Type: application/octet-stream
Size: 227 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20241211/29370ea3/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIFF.ws
Type: application/octet-stream
Size: 8811 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20241211/29370ea3/attachment-0001.obj>