[m-rev.] for post-commit review: implement PROPOSED searches for .a, .init, .jar and .dll files

Zoltan Somogyi zoltan.somogyi at runbox.com
Wed Dec 4 02:58:10 AEDT 2024



On Tue, 3 Dec 2024 19:10:19 +1100, Julien Fischer <jfischer at opturion.com> wrote:
> > I think that the conceptually cleanest solution of this bug is to make
> > the --libgrade option serve only the second purpose, eliminating (1)
> > from the preference order entirely. We would compute the set of installed
> > stdlib grades in handle_options.m just after we compute chosen_stdlib_dir,
> > and record the result in a new slot in the globals structure.
> 
> That seems a reasonable suggestion.

Then I will implement it, including the include/exclude-component bits.

But before I do, I wanted to separate out the code that sets up chosen_stdlib_dir.
The attached diff does this. It has no logic changes that need to be reviewed,
but it does have a big new XXX that describes an issue that would arise if/when
we started using chosen_stdlib_dir more widely. I am requesting feedback
on that XXX, and particularly on the two pathways forward it describes.

Zoltan.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: Log.ho
Type: application/octet-stream
Size: 348 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20241204/037c0394/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIFF.ho
Type: application/octet-stream
Size: 15333 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20241204/037c0394/attachment-0003.obj>


More information about the reviews mailing list