[m-rev.] request for test cases: libdir_map in make.library_install.m

Zoltan Somogyi zoltan.somogyi at runbox.com
Fri Aug 23 21:43:52 AEST 2024



On Fri, 23 Aug 2024 11:48:49 +1000, Julien Fischer <jfischer at opturion.com> wrote:
> On Fri, 23 Aug 2024 at 03:22, Zoltan Somogyi <zoltan.somogyi at runbox.com> wrote:
> > OK. Since I don't know of any libraries more complex than
> > complex_numbers, and it seems that you guys don't have any either
> > that work without --use-grade-subdirs, I would say that this diff
> > is now as tested as it is going to be.
> 
> I now have G12 building without --use-grade-subdirs and can report
> that it builds, installs and passes its regression tests using the mli3a
> diff.  (I reviewed the contents of the install directory and cannot see
> anything amiss there.)

Thanks for that.

The way I intended to check the diff on the complex_numbers library was to

- install the library using mmc --make libcomplex_numbers.install using
  a compiler without the diff to one install prefix (ip1);

- install the library using mmc --make libcomplex_numbers.install using
  a compiler with the diff to another install prefix (ip2);

- do a recursive diff between ip1 and ip2.

The last step turns out not to work, because diff barfs on the symlinks to "..".
However, I could still do "ls -R" on both ip1 and ip2, do sed -e 's/ip2/ip1/'
on the output of the second ls -R, and compare the results. That is enough
to test the diff, since the diff itself has no way to effect the *contents* of the files
being installed; it can affect only whether and where they are installed.

Do you intend to review this diff?

Zoltan.





More information about the reviews mailing list