[m-rev.] for review: carve two new modules out of write_deps_file.m

Julien Fischer jfischer at opturion.com
Fri Aug 2 17:11:31 AEST 2024


On Thu, 1 Aug 2024 at 23:35, Zoltan Somogyi <zoltan.somogyi at runbox.com>
wrote:

> Since this diff has no algorithmic changes and just moves code around,
> the only thing worth reviewing are the names of the new modules.
>
> Note that the best name for the new generate_mmakefile_fragments module
> is (sort-of) already taken. generate_dep_d_files.m does NOT actually
> generate
> .dep and .d files; it generates most of the information from which the new
> generate_mmakefile_fragments.m generates the contents of those files.
> The rest of that info comes from the code that now remains in
> write_deps_file.m.
> I will look into whether that code should be moved into
> generate_dep_d_files.m
> after this diff is committed.
>

The new module names (and diff) look fine.

Julien.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20240802/7744e039/attachment.html>


More information about the reviews mailing list