[m-rev.] for review: add color to the diagnostic generated by typecheck_errors.m

Zoltan Somogyi zoltan.somogyi at runbox.com
Sun Apr 28 12:51:11 AEST 2024


On 2024-04-28 12:46 +10:00 AEST, "Julien Fischer" <jfischer at opturion.com> wrote:
>>     Issue five. If a line either started out colored or contained pieces
>>     that started colors, we marked it to be followed by a color reset
> 
> s/colors/colored/

"started colored" does not make sense. How about "started a color"?

>>     when it is printed. However, if the color was already reset by pieces
>>     that are also contained in the line, so that the color stack was empty
>>     at the end of the line, then this final additional reset was redundant.
>>     Arrange not to print such redundant resets, also in the interest of
>>     making .err_exp files easier to check.
>>
>>     Improve the debugging infrastructure a bit.
>>
>>     Don't duplicate blank lines zero times.
> 
> ...
> 
>> tools/bootcheck:
>>     Prevent the NO_COLOR environment variable from overriding those enables.
> 
> This diff does not contain any changes to the bootcheck script.

That change, which I copied from the internet, did not pan out; I will delete the entry.
If you know how to unset an envvar that works in both the original sh and in bash,
please tell me.

Zoltan.


More information about the reviews mailing list