[m-rev.] for review: colour in error messages

[Julien Fischer]

On Sat, 27 Apr 2024, Zoltan Somogyi wrote:

On 2024-04-24 18:26 +10:00 AEST, "Zoltan Somogyi" <zoltan.somogyi at runbox.com> wrote:
>> 4. How should we test this capability? We could pick a standard
>> set of colours (the default set should work) and update the .err_exp
>> files to contain the resulting terminal escape sequences. Or we could
>> add the expected .err files with the escape sequences as new .err_exp2 files,
>> leaving the original .err_exp file without those sequences.
>> Neither of those would enable us consistently keep testing error messages
>> both with colour enabled and with colour disabled.
>> 
>> We could design a mechanism for executing each test case in invalid* and
>> in warning with color both enabled and disabled, with a separate set of
>> .err_exp files for each case.
>
> In the absence of an objection by then, on monday around lunchtime,
> I intend to start implementing the first proposal above, i.e. including the
> terminal escape sequences for the default color scheme in .err_exp files.

The first scheme is fine with me.

Julien.