[m-rev.] for review: check_libgrades

Zoltan Somogyi zoltan.somogyi at runbox.com
Sun Apr 21 15:49:09 AEST 2024


On 2024-04-21 15:45 +10:00 AEST, "Julien Fischer" <jfischer at opturion.com> wrote:
>>> This appears to bypass the existing libgrades check entirely :-(
>>
>> Do you know what code path is missing the check?
> 
> No, although I suspect we do the libgrade check *before* we have
> accounted for the effects of file specific vraiables.

That is my intuition as well. I will look into it, as a separate change.

> I think for users that's fine, as they are the only things they are
> likely to be doing.  We don't currently do the library grade check
> when building target language files (e.g. c., .java, or .cs targets)
> or object files.  Since those can be dependent on installed libraries
> (e.g. for interface files etc), maybe we should?

Ok, that convinced me. But in that case, the cache *is* a good idea,
so I will keep it, modified as in my previous email.

Zoltan.


More information about the reviews mailing list