[m-rev.] for post-commit review: strip explicit default func modes from diagnostics

Julien Fischer jfischer at opturion.com
Sun Apr 14 15:20:19 AEST 2024


On Sun, 14 Apr 2024, Zoltan Somogyi wrote:

> Strip default function modes from diagnostics.
> 
> compiler/prog_mode.m:
> compiler/prog_type.m:
>     Add a new parameter to the operations that strip module qualifiers
>     from types and modes, which can ask for the replacement of ho_inst_infos
>     that explicit list
>
>         all of a function's non-return args as being input,
>         the function's return arg as being output, and
>         the function being det
>
>     which together specify the default for functions, with
>     none_or_default_func. The point is to avoid printing unnecessary
>     and potentially distracting detail in error messages.
> 
> compiler/prog_util.m:
>     Add the maybe_set_default_func type, which controls the above behavior.
>     Add it here because it is needed in the interface of both prog_mode.m
>     and prog_type.m, and neither imports the other in the interface.

...

That's fine.

Julien.


More information about the reviews mailing list