[m-rev.] for review: write direct to .err files

[Julien Fischer]

On Thu, 14 Sep 2023, Zoltan Somogyi wrote:

> For review by anyone. I am particularly seeking feedback
> on a big new comment about call pair nesting in make.build.m.

I cannot think of an instance when such call pair nesting could occur.
Peter, can you?

In any case, I think the change is fine as you will still end up with
the severity_error errors in the .err file (and they're the ones a user
needs to address.)

> Write direct to .err files if possible.
> 
> compiler/make.build.m:
>     If the compiler has not yet written to a module's .err file, then direct
>     the output from processing that module directly there. Use the old
>     algorithm, which is to direct that output to a temp file, and then
>     appending that the contents of the temp file to the .err file later,
>     only if this compiler invocation *has* written to the .err file before.
>     This should save the cost of a file copy in such cases.
>
>     Change the interface of the predicates that open and close the module error
>     stream to make the above possible.
> 
> compiler/make.module_dep_file.m:
> compiler/make.module_target.m:
> compiler/make.program_target.m:
>     Conform to the change in the interface.

That's looks fine.

Julien.