[m-rev.] for review: improve dir./

[Zoltan Somogyi]

On 2023-09-12 08:47 +10:00 AEST, "Julien Fischer" <jfischer at opturion.com> wrote:
>> For review and trying out by Julien on Windows, though I would
>> also like Peter's opinion on the questions below.
> 
> An hlc.gc bootcheck on Cygwin succeeds and tests/hard_coded/dir_test
> passes.
> 
> An hlc.gc bootcheck with 64-bit MSVC succeeds, but
> tests/hard_coded/dir_test fails with one point of different.
> (The relevant part of the test log is attached.)
> 
> (I'm still to test MinGW64, but I don't expect it to be any different
> to the MSVC case.)

Thanks for that. Can I take it that there are no review comments, or are those
still to come?

Is the test failure on 64 bit MSVC new, or did the test fail before this diff?

If it is new, can you please step through the logic of dir./ and see which
part of the condition of the if-then-else that selects between

- adding a / between the dirname and the filename, and
- not adding a /

fails on MSVC, and why? Making a copy of the logic outside the library for simpler debugging.

Zoltan.