[m-rev.] for review: improve dir./

Julien Fischer jfischer at opturion.com
Sun Sep 10 20:32:41 AEST 2023


On Sun, 10 Sep 2023, Zoltan Somogyi wrote:

> This diff moves closer to the scheme I outlined a few days ago.
>
> For review and trying out by Julien on Windows, though I would
> also like Peter's opinion on the questions below.
>
> Is the new predicate that this diff exports from dir.m generally useful?
> If yes, I will add an entry to NEWS; otherwise, I will move its declaration
> to the implementation section.

I don't think it's more generally useful.

> The comment now in the body of that predicate is a copy of the comments
> on the two pieces of code that the new predicate factors out. Can someone
> propose a better, more unified wording for it?
>
> Can the documentation of that predicate and the other new internal
> preds be improved, and if so, how?

I don't have any immediate suggestion; I'll take a look post-commit.

The diff looks fine.
(My laptop is occupied with testing for 22.01.8 at the moment, I'll run
some tests of this when that is done.)

Julien.


More information about the reviews mailing list