[m-rev.] for possible post-commit review: test_helper_N in valid_seq

Julien Fischer jfischer at opturion.com
Sun Sep 10 20:10:37 AEST 2023


On Sun, 10 Sep 2023, Zoltan Somogyi wrote:

> Rename X's aux modules as X_helper_N in valid_seq.
> 
> Do this after renaming the main modules of tests that either
> 
> - had names that did not even attempt to describe what problem
>   they were intended to test for, or
> - had names that include either a "test_" prefix or a "_main" suffix.
> 
> This ended up renaming most of the modules in this directory. The reason
> for this is that many tests' names had an "intermod_" or "nested_" prefix.
> This was useful in the valid directory, where these tests originally were,
> but it is not useful here, since these tests are in the valid_seq directory
> to be executed sequentially *precisely because* they involve multiple modules.

That's fine.

Julien.


More information about the reviews mailing list