[m-rev.] diff: use io.write_prefixed_lines in more places

Peter Wang novalazy at gmail.com
Mon Sep 4 10:58:36 AEST 2023


On Mon, 04 Sep 2023 10:29:11 +1000 Julien Fischer <jfischer at opturion.com> wrote:
> 
> On Mon, 4 Sep 2023, Peter Wang wrote:
> 
> > On Sun, 03 Sep 2023 23:27:18 +1000 Julien Fischer <jfischer at opturion.com> wrote:
> >>
> >> Use io.write_prefixed_lines in more places.
> >>
> >> profiler/options.m:
> >>      Use io.write_prefixed_lines for writing the usage message.
> >>
> >>      Add -? as a synonym for --help.
> >
> > Why add -?
> 
> Because other parts of the system, e.g. mmc, already support that
> synonym and because that is the option commonly used on Windows.

Fair enough, I didn't know that.

I think -? is a bad idea on Unix where ? is a special character in
shells so needs to be quoted (yes, you can get away with not quoting
unless the directory happens to contain a file name that would match,
depending on the shell). We don't follow any other Windows command
line conventions so I don't think that's important.

I suggest we not propagate -? to more parts of the system.
For programs where we have accepted -?, we could remove it or
undocument it.

Peter


More information about the reviews mailing list