[m-rev.] for review: linked target extension map
Julien Fischer
jfischer at opturion.com
Tue Oct 24 12:18:22 AEDT 2023
On Tue, 24 Oct 2023, Zoltan Somogyi wrote:
> On 2023-10-24 12:12 +11:00 AEDT, "Julien Fischer" <jfischer at opturion.com> wrote:
>> On systems where we do not support shared libraries (or where they have been
>> explicitly disabled) some of the above will collide since that case we set
>> shared_library_extension to be library_extension. For example, Mercury.config
>> on my Windows system contains:
>>
>> --object-file-extension ".o"
>> --pic-object-file-extension ".o"
>> --executable-file-extension ".exe"
>> --shared-library-extension ".a"
>> --library-extension ".a"
>
> I can handle that by using the same approach for library_extension
> and shared_library_extension as the current code uses for object_extension
> and pic_object_extension. Do you see any problems with that approach?
No, I don't see any problems.
The diff looks fine otherwise.
Julien.
More information about the reviews
mailing list