[m-rev.] for post-commit review: pass all ProgressStreams and most ErrorStreams topdown
Julien Fischer
jfischer at opturion.com
Tue Oct 17 21:32:09 AEDT 2023
On Tue, 17 Oct 2023, Zoltan Somogyi wrote:
> Delete all calls get_progress_output_stream ...
>
> ... and almost all all calls to get_error_output_stream. Replace them
> with ProgressStreams and ErrorStreams passed down from higher in the
> call tree.
>
> Use ProgressStreams, not ErrorStreams, to write out error messages about
> any failures of filesystem operations. These are not appropriate to put
> into a module's .err file, since they are not about an error in the
> Mercury code of the module.
That looks fine.
Julien.
More information about the reviews
mailing list