[m-rev.] for review: new machinery in make.dependencies.m

[Zoltan Somogyi]

On 2023-10-02 17:51 +11:00 AEDT, "Peter Wang" <novalazy at gmail.com> wrote:
> On Sat, 30 Sep 2023 02:57:39 +1000 "Zoltan Somogyi" <zoltan.somogyi at runbox.com> wrote:
>> For review by anyone. I am particularly seeking feedback
>> on whether you guys think the few test cases for which the
>> old/new comparison in the diff detected changes are
>> indicative of a problem with this diff, or not. (I have looked
>> at it and couldn't decide, maybe you have some ideas
>> I have overlooked. The failure reports for two of the
>> test cases are attached; the others are similar.)
>> 
>> I am also depending on you guys to test out this diff
>> on real code, since you work with code bases using mmc --make,
>> which I don't do. I would also like to know whether you want to
>> do such tryouts before this diff is committed, or after.
> 
> The diff looks okay.
> 
> I tested it briefly on a few projects without encountering any aborts.
> I only tested the C backends.

Thanks for that.

> I found that swapping the order of the FindDeps call (old mechanism)
> and the find_dep_specs call (new mechanism)
> in find_target_dependencies_of_module, before eqv_states("int012", ...),
> changes which version gets the additional entry for bug506_helper_1.
> ...
> I think whichever call is made first has the side-effect of making the
> bug506_helper_1.int3 file, affecting the results of the second call.

That was my guess as well, but the sizes of the differences between
the two versions made it impossible, for me at least, to be sure.

I am committing the diff. Please tell me about any problems
that may be caused by it.

Zoltan.