[m-rev.] for post-commit review: --show-movability

[Zoltan Somogyi]

On 2023-10-01 20:59 +11:00 AEDT, "Julien Fischer" <jfischer at opturion.com> wrote:
> 
> On Sun, 1 Oct 2023, Zoltan Somogyi wrote:
> 
>> I am seeking opinions on the name of the new option,
>> which generates reports such as the ones attached,
>> and on its documentation. Once we have consensus
>> on that, I will update doc/reference_manual.texi,
>> and also NEWS.md if people think this is a good idea.
> 
> I think that is a good idea.
> 
>> Add a new option --show-movability.
> 
> Perhaps, --show-pred-movability.

That could be read as not applying to functions.

>> +    ( if set_tree234.is_empty(MovingStayingPredIdSet) then
>> +        MovingStayingPieces = []
>> +    else
>> +        MovingStayingPredPieces = name_set_to_line_pieces(ModuleInfo,
>> +            MovingStayingPredIdSet),
>> +        MovingStayingPieces =
>> +            [words("However, the following local predicates and/or functions"),
>> +            words("are reachable both from code being moved and"),
>> +            words("code that is staying, which means that they would"),
>> +            words("need to be either duplicated, or, if included in only"),
>> +            words("one of the two modules, old and new, they would"),
>> +            words("need to be exported from the module they end up in"),
>> +            words("to be accessible from the other module."),
>> +            words("Neither options is usually a good idea.")] ++
> 
> s/options/option/

Will fix.

Thanks.

Zoltan.