[m-rev.] for review: convert parse trees to strings

Zoltan Somogyi zoltan.somogyi at runbox.com
Wed Nov 1 18:51:54 AEDT 2023


On 2023-11-01 16:53 +11:00 AEDT, "Julien Fischer" <jfischer at opturion.com> wrote:
>>> So it only applies to a single module?
>>
>> What is your alternative?
> 
> What prompted my question was the arrangement I have in mercury_json,
> where most of the work is subcontracted to (private) submodules.  That's
> not uncommon -- the examples in the compiler and term_io are just not
> large enough to warrent it. My suggestion would be that at minimum, the
> optimisation should apply to a module plus its child modules.

Agreed. That is a scope that is simple to define, to understand,
and also to implement.

>> Does anyone object to me committing this diff without this new pragma
>> in place? I would prefer to do so, to reduce the risk of conflicts, accepting
>> the temporary perf penalty.
> 
> No, go ahead and commit.

Thanks.

Zoltan.


More information about the reviews mailing list