[m-rev.] for review: mlds_to_{cs,java}_type.m
Julien Fischer
jfischer at opturion.com
Mon May 8 09:52:27 AEST 2023
On Mon, 8 May 2023, Zoltan Somogyi wrote:
> 2023-05-06 02:02 GMT+10:00 "Julien Fischer" <jfischer at opturion.com>:
>>
>> That comment is not correct; special handling is required when the r-value
>> is an enum.
>
> The attached diff addresses both these concerns, and contains other changes
> as well. Thank you.
>
> Was that email the entire review, or is there more to come?
I don't have any further review comments.
> Fix/update comments in mlds_to_{cs,java}_stmt.m.
...
> diff --git a/compiler/ml_type_gen.m b/compiler/ml_type_gen.m
> index fafeff45a..a92716771 100644
> --- a/compiler/ml_type_gen.m
> +++ b/compiler/ml_type_gen.m
> @@ -288,11 +288,12 @@ ml_gen_hld_enum_type(Target, TypeCtor, TypeDefn, CtorRepns,
> % Enums don't import anything.
> Imports = [],
>
> - % Make all Java classes corresponding to types implement the MercuryType
> - % interface and extend the MercuryEnum class.
> (
> Target = ml_target_java,
> + % Java classes implementing enums extend the % MercuryEnum class.
There's a stray '%' there.
Julien.
More information about the reviews
mailing list