[m-rev.] for post-commit review: the by-example chapter

[Mark Brown]

Hi Zoltan,

On Wed, Mar 22, 2023 at 4:47 PM Zoltan Somogyi
<zoltan.somogyi at runbox.com> wrote:
>
> For review by Mark. The diff contains XXXs marking questions for you,
> and/or places that need to be looked at further.

Thanks, that's a big improvement.

Diff is attached that fixes most XXXs as suggested, although I've left
a couple that I'll get back to. There were a couple of minor points in
your change, which I fixed along with this change.

I'll go ahead and push this one since it's parts that you've already
reviewed, but I'll leave off on further pushing while you're still
reading it (sorry about that!)

>
> For Peter & Julien: was there a time when we *formally* supported
> ISO 8859-1 characters in strings, or was any such support just
> a side effect of support for ASCII strings? I don't remember,
> and you guys were much more involved in i18n than I was.

I left an XXX for this one, but I take it from Julien's answer that we
can just say ASCII.

Cheers,
Mark

>
> Zoltan._______________________________________________
> reviews mailing list
> reviews at lists.mercurylang.org
> https://lists.mercurylang.org/listinfo/reviews
-------------- next part --------------
A non-text attachment was scrubbed...
Name: diff
Type: application/octet-stream
Size: 10669 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20230323/4856ad9f/attachment-0001.obj>