[m-rev.] for review: fix github issue #116
Julien Fischer
jfischer at opturion.com
Wed Mar 22 02:03:07 AEDT 2023
On Wed, 22 Mar 2023, Zoltan Somogyi wrote:
> 2023-03-22 01:36 GMT+11:00 "Julien Fischer" <jfischer at opturion.com>:
>> Building programs with --intermodule-optimization fails when using a library
>> containing submodules that was *not* installed with --intermodule-optimization
>> enabled. This is because the compiler is trying to find the .int0 files for the
>> library, but these are only installed when the library is built with
>> --intermodule-optimization enabled. The fix is to always install any .int0
>> files for a library.
>>
>> compiler/make.program_target.m:
>> compiler/write_deps_file.m:
>> Always install the .int0 files for libraries.
>
> This diff looks like it fixes the issue for mmc --make. Does the issue need fixing
> when install is done by mmake?
The change to write_deps_file.m is the fix for this with mmake.
> I don't know whether any more parts of the mmc --make need updating,
There shouldn't be; library installation for mmc --make is all handled by
code in make.program_target.m.
> but the parts of the diff that are there look good.
Thanks for the review!
Julien.
More information about the reviews
mailing list