[m-rev.] for review: start using the new code in file_names.m
Julien Fischer
jfischer at opturion.com
Tue Jun 20 21:37:56 AEST 2023
On Mon, 19 Jun 2023, Zoltan Somogyi wrote:
> On 2023-06-19 13:53 +02:00 CEST, "Julien Fischer" <jfischer at opturion.com> wrote:
>>>> Unexpected: FILENAME
>>>> MISMATCH 1 for
>>>> ext_other(other_ext(".exe"))/newext_exec_gs(ext_exec_exec_opt):
>>>> Mercury\hlc.gc\x86_64-w64-mingw32\Mercury\exes\hello.exe vs
>>>> Mercury\hlc.gc\x86_64-w64-mingw32\Mercury\bin\hello.exe
>>>
>>> What is the value of executable_file_extension option in that case?
>>
>> ".exe"
>
> I should have seen that from the mismatch message.
>
>>> At this point, I would propose that we disable sanity checks in the
>>> specific case where the newext asks for the lookup of the value
>>> of an option. For those, what should matter is whether all parts of the
>>> system agree on the directory where to put the file, not whether this
>>> agrees with the old system, because I think the old system needs
>>> some rationalization anyway.
>>
>> Clearly ;-) I have no objection to disabling the sanity checks in
>> the specific case above.
>
> The attached diff, which includes the one you sent, does this.
I assume you are intending to commit this at some point?
Julien.
More information about the reviews
mailing list