[m-rev.] for post-commit review: newext_user_ngs

[Julien Fischer]

On Mon, 5 Jun 2023, Zoltan Somogyi wrote:

> Add a newext_user_ngs category of extensions.
> 
> compiler/file_names.m:
>     The existing newext_user category contains extensions whose files
>     are always put into the current directory. The new newext_user_ngs category
>     contains extensions whose files are put into the current directory
>     only with --no-use-subdirs; with --use-subdirs, they are put into the
>     (non-grade-specific, ngs) Mercury/<extension>s subdirectory.
>
>     The assignment of intended-for-the-user extensions to one or the other
>     of these categories is questionable, but the right time to do any
>     reassignments will be after the new extension system is fully in place.
>
>     Rename the .order-trans-opt extension to .order_trans_opt,
>     since all other extensions separate words with underscores, not hyphens.
> 
> compiler/generate_dep_d_files.m:
>     Rename the .order-trans-opt extension to .order_trans_opt.
> 
> diff --git a/compiler/file_names.m b/compiler/file_names.m
> index d51b0837b..d118df380 100644
> --- a/compiler/file_names.m
> +++ b/compiler/file_names.m
> @@ -980,7 +980,15 @@ make_include_file_path(ModuleSourceFileName, OrigFileName, Path) :-
>
>      ;       newext_user(string)
>              % Compiler-generated files that are intended to be read
> -            % by the programmer, such as .err files.
> +            % by the programmer, such as .err files, which are always put
> +            % into the current directory.
> +
> +    ;       newext_user_ngs(string)
> +            % Compiler-generated files that are intended to be read
> +            % by the programmer, such as .err files, which will be put

Using .err as an example looks wrong; .err files go in newext_user don't they?

Unrelated: .dep_err files don't seem to be mentioned at all.

> +            % into the current directory with --no-use-sibdirs, but which
>

s/sibdirs/subdirs/

> +            % will be put into a non-grade-specific subdirectory with
> +            % --use-subdirs.
>
>      ;       newext_make(string)
>              % These suffixes are used not to create filenames, but to

Julien.