[m-rev.] for review: avoid a spurious warning from configure

Julien Fischer jfischer at opturion.com
Wed Jul 26 16:08:54 AEST 2023


On Wed, 26 Jul 2023, Peter Wang wrote:

> On Wed, 26 Jul 2023 14:36:03 +1000 Julien Fischer <jfischer at opturion.com> wrote:
>>
>> Avoid a spurious warning from configure.

...

>> @@ -4512,18 +4513,17 @@ case "$FULLARCH" in
>>           esac
>>           ;;
>>   esac
>> -
>> -# We can't put the call to MSG_CHECKING at the start of the case statement
>> -# above, because of the nested check in the lcc case. So we just put it here
>> -# immediately before the MSG_RESULT call.
>> -AC_MSG_CHECKING([options for static linking])
>>   AC_MSG_RESULT($LD_STATIC_FLAGS)
>> -case "$LD_STATIC_FLAGS" in
>> -    "")
>> -        AC_MSG_WARN(
>> +
>> +if test "$USING_MICROSOFT_CL_COMPILER" = "no"
>> +then
>> +    case "$LD_STATIC_FLAGS" in
>> +        "")
>> +            AC_MSG_WARN(
>>   ['mmc --linkage static' and 'ml --static' not implemented with
>>   ****    this C compiler ('$CC').])
>> -esac
>> +    esac
>> +fi
>
> Delete the **** prefix; don't try to wrap the line.

Done.

> The message could be less verbose, e.g.
> checking options for static linking: unknown for this C compiler ('$CC')

I have changed it to read:

      options for static linking unknown for this C compiler ('$CC').

> Add ;; at the end of the clause.

Done.

Julien.


More information about the reviews mailing list