[m-rev.] for review: Defer SHARED_LIBS assignment in ml script.
Peter Wang
novalazy at gmail.com
Thu Dec 14 15:27:34 AEDT 2023
On Thu, 14 Dec 2023 15:12:31 +1100 Julien Fischer <jfischer at opturion.com> wrote:
>
> On Thu, 14 Dec 2023, Peter Wang wrote:
>
> > scripts/ml.in:
> > Assign SHARED_LIBS only when it will actually be used,
> > as the default value of SHARED_LIBS set by configure
> > may invoke "gcc -print-libgcc-file-name" in a command substitution.
>
> That's fine. Presuambly, this is just for performance reasons?
Yes, though I haven't tried to measure the difference.
I noticed it because nearly 80% the calls to ccache on my system were
"Uncacheable" and, of those, 94% were due to "No input file" --
likely most of those due to ml running "gcc -print-libgcc-file-name".
Peter
More information about the reviews
mailing list