[m-rev.] for post-commit review: touched_files
Peter Wang
novalazy at gmail.com
Mon Dec 11 12:21:51 AEDT 2023
On Sat, 09 Dec 2023 22:19:47 +1100 "Zoltan Somogyi" <zoltan.somogyi at runbox.com> wrote:
>
> On 2023-12-09 14:14 +11:00 AEDT, "Peter Wang" <novalazy at gmail.com> wrote:
> > On Sat, 09 Dec 2023 12:34:04 +1100 "Zoltan Somogyi" <zoltan.somogyi at runbox.com> wrote:
> >>
> >> On 2023-12-09 01:02 +11:00 AEDT, "Zoltan Somogyi" <zoltan.somogyi at runbox.com> wrote:
> >> >
> >> > On 2023-12-08 22:17 +11:00 AEDT, "Zoltan Somogyi" <zoltan.somogyi at runbox.com> wrote:
> >> >> The attached diff has bootchecked in hlc.gc, and is partway through stage 3
> >> >> in a C# bootcheck.
> >> >
> >> > The bootcheck has finished with the expected number of test case failures.
> >>
> >> In the absence of a review by then, I intend to commit this in about five hours.
> >
> > I'll review it on Monday. Your plan sounds fine.
>
> Thanks for that.
It looks fine. The only comment I have is that the make_lhs_files fields
have "tf_" prefixes.
> Here is the next installment, for your post-commit review.
> It implements the outline in my previous email.
I think you meant to attach the commit "Separate lhs targets by whether
they have date files." It looks fine as well.
Peter
More information about the reviews
mailing list