[m-rev.] for post-commit review: explicit streams in analysis*.m

[Julien Fischer]

On Fri, 7 Apr 2023, Zoltan Somogyi wrote:

> Use explicit streams in analysis*.m.
> 
> compiler/analysis.m:
> compiler/analysis.file.m:
>     Switch to using explicit streams.
>
>     Use io.format when relevant.
>
>     Give some fields, predicates and variables more meaningful names.
>
>     Replace some rafe-isms with code in our usual coding style.

I don't recall Ralph ever working on the analysis framework, I suspect
they are actually Simon-isms.

>     Add XXXs for possible future improvements.
>
>     Replace the flag that says whether debug is enabled with a maybe
>     wrapped around the stream where debug output should go.
> 
> compiler/handle_options.m:
>     Initialize the maybe debug stream.
> 
> compiler/Mercury.options:
>     Stop disabling the warning for the use of implicit streams
>     for analysis.m and analysis.file.m.

That's fine.

Julien.