[m-rev.] for review: simplify some code in error_util.m

[Zoltan Somogyi]

On Wed, 12 Oct 2022 15:58:18 +1100 (AEDT), Julien Fischer <jfischer at opturion.com> wrote:

> 
> On Wed, 12 Oct 2022, Zoltan Somogyi wrote:
> 
> > On Wed, 12 Oct 2022 14:26:37 +1100 (AEDT), Julien Fischer <jfischer at opturion.com> wrote:
> >>> Any objections, or ideas for better module names?
> >>
> >> No objections from me.
> >>
> >> The diff looks fine.
> >
> > Thank you.
> >
> > I just thought of something else. Splitting error_util.m
> > will require touching many modules, so I thought
> > I would rename the format_component type to
> > format_piece, because we already use Pieces
> > as the standard variable name to refer to lists of
> > format_components. This would require touching
> > the same modules, so it makes sense to do both
> > at the same time. Any objections?
> 
> No.

The attached diff does both the breakup and the rename.
The new modules are called error_spec.m, write_error_spec.m,
error_type_util.m and error_sort.m. People may want to have
a look at the change to compiler/notes/compiler_design.html,
but the rest of the diff is trivial.

Zoltan.



-------------- next part --------------
A non-text attachment was scrubbed...
Name: Log.eu2
Type: application/octet-stream
Size: 2208 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20221012/19840b37/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIFF.eu2
Type: application/octet-stream
Size: 468131 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20221012/19840b37/attachment-0003.obj>