[m-rev.] for post-commit review: version_store.m
Peter Wang
novalazy at gmail.com
Thu May 12 14:39:09 AEST 2022
On Thu, 12 May 2022 13:55:06 +1000 "Zoltan Somogyi" <zoltan.somogyi at runbox.com> wrote:
> Use logic programming style in version_store.m.
>
> library/version_store.m:
> Many operations of this module have both predicate and function forms.
> Instead of implementing the predicates in terms of the functions,
> do the reverse. Make the auxiliary routines predicates as well,
> in order to allow the use of state variables.
>
> Improve the documentation.
>
> library/version_array.m:
> Change some auxiliary routines from functions to predicates,
> for the same reason.
That's fine.
Peter
More information about the reviews
mailing list