[m-rev.] for review: fix mantis bug #559, step 2
Zoltan Somogyi
zoltan.somogyi at runbox.com
Sat May 7 11:11:12 AEST 2022
2022-05-07 11:00 GMT+10:00 "Julien Fischer" <jfischer at opturion.com>:
> Results attached. Baseline is commit 2cb46b2, while modified is commit
> b96a90f. (I meant to benchmark both asm_fast.gc and hlc.gc at -O2 and
> -O5, but didn't realise I had set things up incorrectly until this
> morning; let me know if you you want to run the other combinations).
Thanks for that. I think these four results are sufficient to show that the
new approach is not significantly slower, and since it can handle much
larger disjunctions, it should definitely be preferred. I will therefore
switch to this approach for conjunctions. I think I will hold off on
doing the same for if-then-else chains, due to lack of need, until
someone has a real need to compile a monster if-then-else chain.
Zoltan.
More information about the reviews
mailing list