[m-rev.] for review: convert mode analysis to use var_tables

[Zoltan Somogyi]

2022-05-02 11:24 GMT+10:00 "Julien Fischer" <jfischer at opturion.com>:
>> > tests/invalid/mode_inf.m:
>>     Modify this test case to make the caller and callee use disjoint
>>     sets of variable names, which is probably why the incorrect variables
>>     in the error message about the callee has not been noticed.
>> > tests/invalid/mode_inf.err_exp:
>>     Expect the updated, and now correct, version of that error message.
> 
> You haven't included the diff for these last two files.

Sorry about that; they are attached now.

>> @@ -222,7 +222,7 @@ modecheck_find_matching_modes([ProcId | ProcIds], PredId, Procs, ArgVars0,
>>      mode_info_get_instvarset(!.ModeInfo, InstVarSet0),
>>      rename_apart_inst_vars(InstVarSet0, ProcInstVarSet, InstVarSet,
>>          ProcArgModes0, ProcArgModes),
>> -    mode_info_set_instvarset(InstVarSet, !ModeInfo),
>> +    mode_info_set_instvarset(InstVarSet, !ModeInfo),    % ZZZ undone where?
>>      mode_info_get_module_info(!.ModeInfo, ModuleInfo),
>>      proc_info_arglives(ModuleInfo, ProcInfo, ProcArgLives0),
> 
> Are these ZZZ comments something you intend to commit?

Yes, but I will act on them and remove them before tonight.

Zoltan.

> The rest looks fine.

Thanks. Please have a look at the diff for the tests,
and say whether I can commit.

Zoltan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIFF.vt19a
Type: application/octet-stream
Size: 1095 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20220502/4f40cb9a/attachment.obj>